Hartmut Holzgraefe  hholzgra

Latest Contributions

issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Index size calculations are not always correct
Comment:
For now I just removed the assertion so rendering does not fail when overflowing the last reserved index column. It "just" produces visually imperfect results instead for now until a real fix exists. This kind of exception happened rarely enough that this approach should be OK-ish for now ...
commit Pushed a commit for hholzgra/ocitysmap on May 01, 2022
do not bail out of index overflows the last reserved column
issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Index size calculations are not always correct
Comment:
I'm also not really sure what to make out of this comment in single_page_renderers.py ``` # NEVER use ctx.scale() here because otherwise pango will # choose different font metrics which may be incompatible # with what has been computed by __init__(), which may # require more columns than expected ! Instead, we have # to trick pangocairo into believing it is rendering to a # device with the same default resolution, but with a # cairo resolution matching the 'dpi' specified # resolution. See # index::render::StreetIndexRenederer::render() and # comments within. ``` near https://github.com/hholzgra/ocitysmap/blob/master/ocitysmap/layoutlib/single_page_renderers.py#L578 this is code that clearly pre-dates my involvement with this code base quite a bit :(
issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Index size calculations are not always correct
Comment:
It would probably be better to take the pre-calculation as a first estimate only, and to add one more index column and re-render in case we detect an overflow on the first try ...
issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Index size calculations are not always correct
Comment:
Hypothesis from the previous comment does not hold, seeing same assertion on Latin-only indexes, too, e.g.: https://print.get-map.org/maps/217317
issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Index size calculations are not always correct
Comment:
The actual problem may be that the index calculations are not wrong in general but fail as they presuppose having to deal with Latin text only. See e.g. the slightly higher index category header bar on the right when Chinese characters are used on the right column: ![Schermafbeelding 2022-04-14 om 10 33 19](https://user-images.githubusercontent.com/451772/166141408-115acded-c495-4904-be60-cf0c4a9751b8.png)
issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Index size calculations are not always correct
Comment:
See e.g. https://print.get-map.org/maps/217269
commit Pushed a commit for hholzgra/ocitysmap on May 01, 2022
fix broken import path to make exception catching actully work
commit Pushed a commit for hholzgra/maposmatic-vagrant on April 25, 2022
get rid of hard coded references to /home/maposmatic
issue closed Closed the issue for hholzgra/ocitysmap
When having uploaded a GPX file the multi page renderer should only render pages that do actually have track or route segments on them.

This used to work in the past, but is somehow broken now, reason for this regression needs to be found.
commit Pushed a commit for hholzgra/ocitysmap on April 24, 2022
add GPX track / route linestrin information again (Issue #51)
issue opened Opened the issue for hholzgra/ocitysmap
When having uploaded a GPX file the multi page renderer should only render pages that do actually have track or route segments on them.

This used to work in the past, but is somehow broken now, reason for this regression needs to be found.
issue comment Commented on the issue of hholzgra/maposmatic
Issue:
Make max. output size checks consistent
Comment:
Hasn't happened in quite a while, might have been fixed by other changes?
commit Pushed a commit for hholzgra/maposmatic on April 24, 2022
package version updates
commit Pushed a commit for hholzgra/ocitysmap on April 24, 2022
remove redundant ORDER BY clauses
issue closed Closed the issue for hholzgra/maposmatic-vagrant
Replace all references to /vagrant/files, /vagrant/inc and /vagrant/cache with $FILEDIR, $INCDIR and $CACHEDIR in all provisioning scripts.

Maybe also make /home/maposmatic configurable ...
issue comment Commented on the issue of hholzgra/maposmatic-vagrant
Issue:
Use path variables everywhere
Comment:
See issue #37 for /home/maposmatic/ hardcoded references removal
issue opened Opened the issue for hholzgra/maposmatic-vagrant
Right now many of the install scripts have /home/maposmatic/ hardcoded into them as main project directory, this should be configurable in the main provision.sh file instead
issue comment Commented on the issue of hholzgra/maposmatic-vagrant
Issue:
Use path variables everywhere
Comment:
All unconditional references to /vagrant/ directory are now replaced, going to create a new case for /home/maposmatic/ dir
commit Pushed a commit for hholzgra/maposmatic-vagrant on April 24, 2022
continue to remove absolute /vagrant/ paths (issue #13)
issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Make Street Index contents configurable
Comment:
The three different functions that retrieve and set up the street, amenities and villages indexes have now been refactored to use the same SQL query generating code. This is a first step towards making these steps configurable instead of being fully defined in Python and SQL code only. Next steps will be to apply even more refactoring to unify the Python part processing the SQL query results, too, and then the final step will be to come up with a configuration file format for specifying index generators.
issue closed Closed the issue for hholzgra/ocitysmap
Currently fails with:

```
Mar 16 11:22:45 print python3[3971885]: ocitysmap.indexlib.commons.IndexDoesNotFitError: Index does not fit in area
Mar 16 11:22:45 print python3[3971885]: raise IndexDoesNotFitError("Index does not fit in area")
Mar 16 11:22:45 print python3[3971885]: File "/home/maposmatic/ocitysmap/ocitysmap/indexlib/StreetIndex.py", line 724, in precompute_occupation_area
Mar 16 11:22:45 print python3[3971885]: index_area = index_renderer.precompute_occupation_area(
Mar 16 11:22:45 print python3[3971885]: File "/home/maposmatic/ocitysmap/ocitysmap/layoutlib/single_page_renderers.py", line 264, in _create_index_rendering
Mar 16 11:22:45 print python3[3971885]: = self._create_index_rendering(index_position)
Mar 16 11:22:45 print python3[3971885]: File "/home/maposmatic/ocitysmap/ocitysmap/layoutlib/single_page_renderers.py", line 135, in __init__
Mar 16 11:22:45 print python3[3971885]: SinglePageRenderer.__init__(self, db, rc, tmpdir, dpi, file_prefix, 'side')
Mar 16 11:22:45 print python3[3971885]: File "/home/maposmatic/ocitysmap/ocitysmap/layoutlib/single_page_renderer/side_index.py", line 18, in __init__
Mar 16 11:22:45 print python3[3971885]: renderer = renderer_cls(self._db, config, tmpdir, dpi, file_prefix)
Mar 16 11:22:45 print python3[3971885]: File "/home/maposmatic/ocitysmap/ocitysmap/__init__.py", line 613, in _render_one
Mar 16 11:22:45 print python3[3971885]: self._render_one(config, tmpdir, renderer_cls,
Mar 16 11:22:45 print python3[3971885]: File "/home/maposmatic/ocitysmap/ocitysmap/__init__.py", line 586, in render
Mar 16 11:22:45 print python3[3971885]: output_count = renderer.render(config, self.job.layout,
Mar 16 11:22:45 print python3[3971885]: File "/home/maposmatic/maposmatic/scripts/render.py", line 508, in run

```

See e.g.:

https://print.get-map.org/maps/210143
issue comment Commented on the issue of hholzgra/ocitysmap
Issue:
Skip index generation instead of failing when index gets too large
Comment:
fixed by catching exception and resetting the layout to "no index" on failure https://github.com/hholzgra/ocitysmap/commit/57dfe1b46c36505286cdcd4de3eaddec7177a7bf
commit Pushed a commit for hholzgra/ocitysmap on April 24, 2022
handle "index does not fit" exception by turning off the index
commit Pushed a commit for hholzgra/ocitysmap on April 23, 2022
make generating index queries simpler, part #3 - complete
commit Pushed a commit for hholzgra/ocitysmap on April 23, 2022
make generating index queries simpler, part #1
commit Pushed a commit for hholzgra/ocitysmap on April 23, 2022
move easting text on UTM grid to be on the map
PR merged Pull request merged hholzgra/ocitysmap on April 23, 2022
move easting numbers on UTM grid lower down so they can be seen on the PDF
+1   -1
2 commits, 1 comments, 1 files changed
commit Pushed a commit for hholzgra/umgebungsplaene on April 19, 2022
generatee JS gettext data files from gettext .po files
commit Pushed a commit for hholzgra/umgebungsplaene on April 19, 2022
Translated using Weblate (German)

Currently translated at 100.0% (63 of 63 strings)

Translation: MapOSMatic/neighborhood
Translate-URL: https://translate.get-map.org/projects/maposmatic/neighborhood/de/